[worldKit-dev] worldkit with mtasc working.

[Brent Pedersen]

actually the bounds test in worldkitImages.isSwfVisible() should be:
if (w > interact.ceast || s > interact.cnorth || e < interact.cwest ||
n < interact.csouth) {



On Thu, Feb 14, 2008 at 9:52 AM, Brent Pedersen <bpederse at gmail.com> wrote:
> hi mikel.
>  i have a patch attached. much of it is just converting substring(str,
>  i, j) into str.substring(i, j) and likewise for length() => .length.
>  then fixing scope where variables are defined inside if/else blocks
>  and used outside and converting types.
>  there was a real bug in worldkitImages.isSwfVisible()
>  thanks for the cool lib. i'll have some uses for it now.
>  -brent
>
>
>
>
>
>
>
>
>  On Thu, Feb 14, 2008 at 8:50 AM, Mikel Maron <mikel_maron at yahoo.com> wrote:
>  >
>  > Excellent news Brent!
>  >
>  > I suppose that it would be easiest if you could produce a diff of just those
>  > relevant changes. After that's reviewed, then could do a second update with
>  > the corrected indentation.
>  >
>  > -Mikel
>  >
>  >
>  >
>  > ----- Original Message ----
>  > From: Brent Pedersen <bpederse at gmail.com>
>  > To: worldkit-dev at lists.brainoff.com
>  > Sent: Thursday, February 14, 2008 3:45:45 AM
>  > Subject: [worldKit-dev] worldkit with mtasc working.
>  >
>  >  hi, i've gone through the code and cleaned up any type problems that
>  > the mtasc compiler (http://www.mtasc.org/) complained about.
>  > it may actually have found a couple of real bugs too. but i can now
>  > get a swf using only mtasc. hurray for open source!
>  >
>  > i tried a svn diff, but that gives 6000+ lines of change-set, because
>  > i made VI fix indentation.
>  > so, there's a svn exported tarball here:
>  > http://toxic.berkeley.edu/~bpederse/wkmtasc/worldkit_mtasc.tgz
>  > that also includes a Makefile so you can just type "make" to get a new
>  > worldkit.swf, or just read it to see the command you
>  > send directly to mtasc.exe if you're on windows.
>  >
>  > i'm not sure if this is expected, but the swf created by mtasc is only
>  > 30kb, while the one from svn is 43KB.  it seems to work as expected...
>  >
>  > i can provide the diff if it'll be used -- the indentation is nice.
>  >
>  > -brent
>  > _______________________________________________
>  > worldkit-dev mailing list
>  > worldkit-dev at lists.brainoff.com
>  > http://lists.brainoff.com/listinfo.cgi/worldkit-dev-brainoff.com
>  >
>  >
>  > _______________________________________________
>  >  worldkit-dev mailing list
>  >  worldkit-dev at lists.brainoff.com
>  >  http://lists.brainoff.com/listinfo.cgi/worldkit-dev-brainoff.com
>  >
>  >
>